[humble] Expose more Writer methods in python interface (backport #1220 and #1339) #1829
+33
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jannik Jose <[email protected]>
Signed-off-by: Emerson Knapp <[email protected]>
JannikJose
requested review from
gbiggs and
james-rms
and removed request for
a team
There was a problem hiding this comment.
@JannikJose Thank you for the backporting PR.
Overall, it looks good. However, I found out that the Python definition for the split_bagfile API was omitted in the backporting commit. Is there a particular reason for that?
Comment on lines
+104
to
+106
| .def("create_topic", &PyWriter::create_topic) | ||
| .def("take_snapshot", &PyWriter::take_snapshot) | ||
| ; |
There was a problem hiding this comment.
@JannikJose Out of curiosity why .def("split_bagfile", &PyWriter::split_bagfile) missed from the original PR https://github.com/ros2/rosbag2/pull/1220/files#diff-f3aa422fd35406262b9209321476913d230c5bcd81b395525719e0166395ce90R103 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #1220 and #1339 to humble, exposing the
close()andtake_snapshot()Writer methods in the python interface